cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-plugin-device-motion pull request: CB-8312 Multiply accele...
Date Mon, 26 Jan 2015 12:29:04 GMT
GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-plugin-device-motion/pull/24

    CB-8312 Multiply accelerometer values by -g on Windows

    This is a fix for [CB-8312](https://issues.apache.org/jira/browse/CB-8312)
    
    The story: Windows implementation of device-motion methods returns acceleration, measrued
in g's (source: https://msdn.microsoft.com/en-us/library/windows/apps/windows.devices.sensors.accelerometerreading.accelerationx).
To be consistent with current plugin's specs, it is necessary to multiply accelerometer result
by G constant (9.81 according to https://github.com/apache/cordova-plugin-device-motion/blob/master/doc/index.md#acceleration)
    
    Also this PR contains additional commit https://github.com/MSOpenTech/cordova-plugin-device-motion/commit/213cd4b76519428484b78cb4292e0070c23d776d
since the PR is based on git://git.apache.org/cordova-plugin-device-motion.git which is currently
out of sync with https://github.com/apache/cordova-plugin-device-motion. This should correct
the sync issue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-device-motion CB-8312

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-device-motion/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 213cd4b76519428484b78cb4292e0070c23d776d
Author: maria.bukharina <maria.bukharina@akvelon.com>
Date:   2014-11-27T16:14:12Z

    CB-8096 Pended auto tests if accelerometer doesn't exist on the device

commit d9db216ed53b5b71a1304eba5c1b6274c04eff94
Author: daserge <daserge@yandex.ru>
Date:   2015-01-15T10:00:32Z

    CB-8312 Multiply accelerometer values by -g on Windows

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message