cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jpchase <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-8210 Remove unused onDestroy chan...
Date Fri, 09 Jan 2015 19:05:14 GMT
GitHub user jpchase opened a pull request:

    https://github.com/apache/cordova-android/pull/146

    CB-8210 Remove unused onDestroy channel

    - Channel was defined as internal event and fired by javascript eval()
    - Rather than change firing of event, simpler to remove as was not used

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jpchase/cordova-android CB8210-remove-ondestroy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #146
    
----
commit 409b1fbdb918364505e782818dbb1854a714e11d
Author: Jason Chase <jasonpchase@gmail.com>
Date:   2015-01-09T18:50:11Z

    CB-8210 Remove unused onDestroy channel
    - Channel was defined as internal event and fired by javascript eval()
    - Rather than change firing of event, simpler to remove as was not used

commit 2cc5f29e91dbdd3aba9471394cd79127b2efab7b
Author: Jason Chase <jasonpchase@gmail.com>
Date:   2015-01-09T19:02:52Z

    CB-8210 Revert unintentional whitespace cleanup

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message