cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...
Date Mon, 05 Jan 2015 06:16:37 GMT
GitHub user sgrebnov opened a pull request:

    https://github.com/apache/cordova-android/pull/143

    CB-8201 Add support for auth dialogs into Cordova Android

    https://issues.apache.org/jira/browse/CB-8201
    
    Makes it possible to provide custom pluggabble logic to process auth challenge (for example
by installing corresponding plugin, sample implementation: https://github.com/msopentech/cordova-plugin-auth-dialog).
    
    *Motivation*
    If you load some resource which requires authentication using android default browser
default login dialog appears, but if you try to load the same resource using cordova app then
no dialog is shown for user and request is failed w/ 401 Unauthorized. So Currently apps have
to provide own JS logic to show web based auth dialog. 
    
    It will be great if Cordova Android offers special functionality (in core or via special
interface plugin developers can extend) to automatically show native auth dialog. This is
extremely useful in corpnet scenarios where all resources requires user to be authenticated.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-android CB-8201

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #143
    
----
commit 05c805b9bc1b9df09449a4c12fb9b4fd5abcf9cb
Author: sgrebnov <v-segreb@microsoft.com>
Date:   2014-12-22T12:58:26Z

    CB-8201 Add support for auth dialogs into Cordova Android

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message