cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lingoer <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: [CB-8270] rename category methods for JS...
Date Thu, 08 Jan 2015 04:20:49 GMT
GitHub user lingoer opened a pull request:

    https://github.com/apache/cordova-ios/pull/124

    [CB-8270] rename category methods for JSON handling with a prefix.

    According to [Apple's documentation](https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/CustomizingExistingClasses/CustomizingExistingClasses.html#//apple_ref/doc/uid/TP40011210-CH6-SW4)
, naming a Category method without a prefix would possibly cause a Name Clash
    
    In CordovaLib/Classes/CDVJSON.h : NSArray(CDVJSONSerializing) 
    The method name should starts with a prefix
    
    Actually, it clashes with the TencentOpenAPI framework which is a major sns platform in
China.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lingoer/cordova-ios CB-8270

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #124
    
----
commit 75e72a53f062115066e2fc9305c8dfb0ad5cfeb8
Author: Ruoyu Fu <ryfu@thoughtworks.com>
Date:   2015-01-08T04:08:37Z

    [CB-8270] rename category methods for JSON handling with a prefix.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message