cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject [iOS][Camera] Re-factor so it is testable
Date Wed, 07 Jan 2015 00:31:03 GMT
FYI.

I've done all the work [1], including adding native unit-tests [2].
The auto tests and manual tests I've done in mobile-spec pass,
including my new unit-tests which only has 3 failures, which is
expected [3].

I'll merge/squash the pull requests within the next few days.

This re-factor was sorely needed because the code has become a
spaghetti mishmash and new pull requests coming in could not be easily
verified that it does not break anything, and the unit tests are
needed for another bug-fix [3]

[1] https://github.com/apache/cordova-plugin-camera/pull/52
[2] https://github.com/apache/cordova-plugin-camera/pull/60
[3] https://issues.apache.org/jira/browse/CB-5942

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message