cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: Remove CDVJson.h from Copy Headers?
Date Thu, 22 Jan 2015 04:03:31 GMT
I've fixed InAppBrowser to call NSJSONSerializer directly, but I'm
certainly leaning towards the change to rename the symbol to be reverted
and re-applied in a 4.0.x branch. Shall I create one?

On Wed, Jan 21, 2015 at 1:40 PM, Shazron <shazron@gmail.com> wrote:

> Sounds good to me to remove it as a public header - we never documented
> support for it for use.
>
> Since it is kinda public already, we should push this for 4.0 because of
>  CDVInAppBrowser (although if we want to do it now, I suppose we could go
> the icky way and detect the existence of either the prefixed or
> non-prefixed version at runtime).
>
> On Wed, Jan 21, 2015 at 8:56 AM, Andrew Grieve <agrieve@chromium.org>
> wrote:
>
> > RE:
> >
> >
> https://github.com/apache/cordova-ios/commit/a98144b8ad63fe714c9f6d274bc9fd98b62575e7
> >
> > issue: https://issues.apache.org/jira/browse/CB-8270
> >
> > We had an unprefixed extension, and prefixing it is a breaking change
> (e.g.
> > CDVInAppBrowser was using it). It really is the right thing to do
> though...
> > We could perhaps delay it for cordova-ios@4.0 though?
> >
> > Also wondering what thoughts are for just taking the opportunity to
> remove
> > CDVJson.h as a public header? Think this just involves removing it from
> the
> > Copy Headers build phase.
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message