cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Barham <Tim.Bar...@microsoft.com>
Subject RE: [GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...
Date Thu, 29 Jan 2015 21:08:37 GMT
Oh, yeah, I see the problem. Paths in jsproj (now jsprojManager) are hard-coded to use "\",
which is not a problem in practice because this code would only normally executed on Windows,
but is a problem when running tests (guess this particular code hasn't been exercised by tests
previously).

-----Original Message-----
From: Jesse [mailto:purplecabbage@gmail.com] 
Sent: Thursday, January 29, 2015 12:04 PM
To: dev@cordova.apache.org
Subject: Re: [GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

The tests are only failing on Travis, which is running MacOS, so it is
probably just related to path separators.

@purplecabbage
risingj.com

On Thu, Jan 29, 2015 at 11:27 AM, Tim Barham <Tim.Barham@microsoft.com>
wrote:

> Thanks Jesse. Do you have any thoughts on the test failures? The failures
> appear to be related to my directory renaming - but the tests pass locally,
> and the commits look good (and identical to what I have locally).
>
> -----Original Message-----
> From: purplecabbage [mailto:git@git.apache.org]
> Sent: Wednesday, January 28, 2015 12:18 PM
> To: dev@cordova.apache.org
> Subject: [GitHub] cordova-lib pull request: CB-8123 Plugin references can
> target spe...
>
> Github user purplecabbage commented on the pull request:
>
>     https://github.com/apache/cordova-lib/pull/155#issuecomment-71907847
>
>     Very cool Tim!
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
Mime
View raw message