cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Josh Soref <jso...@blackberry.com>
Subject RE: Cordova --list option implementation
Date Thu, 22 Jan 2015 01:35:16 GMT
Oh, that problem.

Yes, this is one of the areas where github is really deficient. I'm not saying I want reviewboard
(I didn't like that either).

What I ended up doing is this:
https://github.com/w3c/mediacapture-main/pull/49#issuecomment-68760377 
each version where people reviewed grows an extra branch name, which ensures that people can
reference / browse them.

In principle, as long as you've addressed all the comments, we have email archives which will
let us go back to the comments if we need to.

Also, at least temporarily you can include direct links or at branches for the other versions

[sending this email so I can reboot]

> -----Original Message-----
> From: Murat Sutunc [mailto:muratsu@microsoft.com]
> Sent: Friday, January 16, 2015 2:56 PM
> To: <dev@cordova.apache.org>
> Subject: Re: Cordova --list option implementation
> 
> Im actually doing git --amend now but everytime I push the history is lost due
> to force push. github is not able to save/rebase previous comments. Wish
> there was a better solution for this.
> 
> Sent from my iPhone
> 
> > On Jan 16, 2015, at 11:51 AM, Josh Soref <jsoref@blackberry.com> wrote:
> >
> > You should be doing git commit --amend in general.
> >
> > Rebase is mostly important when someone else committed code and you
> want to have that code too. We want you to rebase your changes onto those
> changes. (It's also helpful for when you want to safely split out changes into
> distinct commits, e.g. if you need to refactor before your changes, or fix
> something that's only tangentially related, but which shouldn't be in your
> main commit.)
> >
> >> -----Original Message-----
> >> From: Murat Sutunc [mailto:muratsu@microsoft.com]
> >> Sent: Friday, January 16, 2015 2:42 PM
> >> To: dev@cordova.apache.org
> >> Subject: RE: Cordova --list option implementation
> >>
> >> Oh.. I've addressed the issues couple times and I thought you reviewed
> the
> >> previous changes. Didn't mean to be pushy, sorry about that.
> >>
> >> I have a question regarding the CR process. I've searched up the wiki but
> >> couldn't find a good answer for this. When addressing issues, is it ok to
> create
> >> a quick fix commit or do we have to rebase every time?
> >>
> >> -----Original Message-----
> >> From: Josh Soref [mailto:jsoref@blackberry.com]
> >> Sent: Friday, January 16, 2015 11:35 AM
> >> To: dev@cordova.apache.org
> >> Subject: RE: Cordova --list option implementation
> >>
> >> No. That's not really how it goes.
> >>
> >> And I'd like people to understand this.
> >>
> >> Things don't just go in the moment there aren't comments.
> >> In general, we give people time to review. And sometimes someone will
> put
> >> a +1 saying "I think it's ready".
> >>
> >> I'm sorry that I didn't give all my comments at once. I generally have to
> look
> >> at things repeatedly in order to work things through.
> >>
> >>> -----Original Message-----
> >>> From: Murat Sutunc [mailto:muratsu@microsoft.com]
> >>> Sent: Friday, January 16, 2015 2:17 PM
> >>> To: dev@cordova.apache.org
> >>> Subject: RE: Cordova --list option implementation
> >>>
> >>> All issues addressed, changes can be merged now.
> >>>
> >>> -----Original Message-----
> >>> From: Murat Sutunc [mailto:muratsu@microsoft.com]
> >>> Sent: Sunday, January 11, 2015 11:53 PM
> >>> To: dev@cordova.apache.org
> >>> Subject: RE: Cordova --list option implementation
> >>>
> >>> I've made the changes wrt what has been discussed:
> >>>
> >>> https://github.com/apache/cordova-cli/pull/205
> >>> https://github.com/apache/cordova-lib/pull/145
> >>>
> >>> Thanks,
> >>> Murat
> >>>
> >>> -----Original Message-----
> >>> From: Josh Soref [mailto:jsoref@blackberry.com]
> >>> Sent: Friday, January 9, 2015 11:39 AM
> >>> To: dev@cordova.apache.org
> >>> Subject: Re: Cordova --list option implementation
> >>>
> >>> Murat Sutunc wrote:
> >>>> At the very least, if you're going to do option 1.b, please make sure
> >>>> that list is a function which is independently reachable via the api
so
> >>>> that js callers can easily get the list of devices for platform[s],
and
> >>>> can determine if the feature is available (by checking for the presence
> >>>> of the api function).
> >>>>
> >>>> [MS] Can you clarify this a bit more. Do you mean like
> >>>> require('./cordova').raw.list(/*args*/)
> >>>
> >>> Something like this, yes, but it'd need to have some indication it's about
> >>> targets in the code portion (which here is just 'raw.list').
> >>> B
> >>
> KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKK
> >>> KKKKKKKKKKCB  [  X  ܚX KK[XZ[
> >>> ] ][  X  ܚX P ܙݘK \X K ܙ B  ܈Y][ۘ[  [X[  K[XZ[
> >>> ] Z[ ܙݘK \X K ܙ B
> >>
> B�KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKK
> >>> KKKKKKKKKKKKKCB��[��X��ܚX�KK[XZ[
> >>
> �]�][��X��ܚX�P�ܙݘK�\X�K�ܙ�B��܈Y][ۘ[��[X[��K[XZ[
> >>>
> >>> �]�Z[�ܙݘK�\X�K�ܙ�B
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >> For additional commands, e-mail: dev-help@cordova.apache.org
> B�KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKK
> KKKKKKKKKKKKKCB��[��X��ܚX�KK[XZ[
> 
> �]�][��X��ܚX�P�ܙݘK�\X�K�ܙ�B��܈Y][ۘ[��[X[��K[XZ[
> 
> �]�Z[�ܙݘK�\X�K�ܙ�B

Mime
View raw message