cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gorkem Ercan" <gorkem.er...@gmail.com>
Subject Re: platforms/plugins save and restore from config.xml
Date Fri, 09 Jan 2015 19:06:03 GMT


On 9 Jan 2015, at 13:35, Michal Mocny wrote:

> -1 on removing experimental.
>
> I love the concept behind this feature, and I applaud Gorkem for 
> actually
> working on pushing it forward,

Thanks just trying to help.

> but I'm still concerned the current design
> is not perfect.  Just today we were discussing storing the list of 
> plugins
> into a package.json if plugins move to npm.

discussing where ?

> The current implementation
> still saves all installed plugins including dependencies and not just 
> what
> was explicitly added.
>
Not anymore, that was the case with the initial implementation. [1] has 
changed that many months ago.

[1] 
https://github.com/apache/cordova-lib/commit/35a3059bbbe5fcabdb74ff30b8c2845d135dada7


> If we add this outside experimental, and document & broadcast it, we 
> will
> have to support it going forward.  That will certainly influence 
> future cli
> designs.
>
I was not aware there was a future cli design discussion.

> -Michal
>
> On Fri, Jan 9, 2015 at 12:08 PM, Gorkem Ercan <gorkem.ercan@gmail.com>
> wrote:
>
>>
>>
>> On 9 Jan 2015, at 10:41, Andrew Grieve wrote:
>>
>> Questions: Would ever not want to use --save? Why not just always 
>> update
>>> config.xml with what plugins you have?
>>>
>>> Eclipse Thym always updates the plugin & platform information to
>> config.xml, and no one complained about it so far.
>>
>> Likewise, would you ever not want to have --shrinkwrap? I think you'd
>>> always want the plugin/platform version listed in there.
>>>
>>>
>> I do not set the shrinkwrap for plugins usually, because without
>> shrinkwrap, the latest version is restored. I usually prefer the 
>> latest
>> with the stable plugins, such as the core plugins.
>> As a reference, Eclipse Thym does not shrinkwrap by default but has a
>> preference you can turn on.
>>
>> With platforms shrinkwrap as default makes sense.
>>
>> On Fri, Jan 9, 2015 at 1:46 AM, Mefire O. <ommenjik@microsoft.com> 
>> wrote:
>>>
>>> Also, I have Pull Requests that implements the --save flag as 
>>> mentioned
>>>> earlier :
>>>>
>>>> - https://github.com/apache/cordova-cli/pull/203
>>>> - https://github.com/apache/cordova-lib/pull/144
>>>>
>>>>
>>>> Thanks,
>>>> Mefire
>>>>
>>>> -----Original Message-----
>>>> From: Mefire O. [mailto:ommenjik@microsoft.com]
>>>> Sent: Thursday, January 8, 2015 10:27 PM
>>>> To: Cordova Dev
>>>> Subject: RE: platforms/plugins save and restore from config.xml
>>>>
>>>> +1 on removing the --experimental flag after fixing the 'variables 
>>>> not
>>>> being saved' bug.
>>>>
>>>> Thanks,
>>>> Mefire
>>>>
>>>> -----Original Message-----
>>>> From: Josh Soref [mailto:jsoref@blackberry.com]
>>>> Sent: Thursday, January 8, 2015 8:49 PM
>>>> To: Cordova Dev
>>>> Subject: Re: platforms/plugins save and restore from config.xml
>>>>
>>>> Until adding plugins saves the variables provided, we really 
>>>> shouldn't /
>>>> can't make this non experimental.
>>>>
>>>> Sent from my BlackBerry 10 smartphone.
>>>> ‎
>>>>
>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message