cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...
Date Thu, 29 Jan 2015 22:12:34 GMT
Github user TimBarham commented on the pull request:

    https://github.com/apache/cordova-lib/pull/155#issuecomment-72114968
  
    The tests use path.join(), but jsproj uses hard-coded backslashes (which is reasonable,
because normally it would only run on Windows). This problem is showing up now because previously
this code wasn’t exercised by tests.
    
    I’m looking to see if it is feasible/reasonable to update jsproj to be platform agnostic,
to the extent it needs to be for tests to pass. I’d prefer that to skipping the tests, so
we get consistent coverage (the tests don’t build projects – just verify that files are
modified as expected).
    
    From: Jesse MacFadyen [mailto:notifications@github.com]
    Sent: Thursday, January 29, 2015 12:12 PM
    To: apache/cordova-lib
    Cc: Tim Barham
    Subject: Re: [cordova-lib] CB-8123 Plugin references can target specific windows platforms.
(#155)
    
    
    You should use path.join( ) in your tests when creating paths so the tests will still
pass on MacOS, or check the environment and skip running your tests altogether.
    
    —
    Reply to this email directly or view it on GitHub<https://github.com/apache/cordova-lib/pull/155#issuecomment-72095389>.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message