cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: [INFRA-8588] Fixed a bug for ASF Build...
Date Thu, 29 Jan 2015 10:54:29 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/23#discussion_r23759837
  
    --- Diff: cordova.conf ---
    @@ -110,6 +108,13 @@ from buildbot.config import BuilderConfig
     from buildbot.process.factory import BuildFactory
     from buildbot.steps.transfer import FileDownload
     
    +def RMCommand(path, **kwargs):
    +    js_script = "var s = require('shelljs'); console.log('removing {path}'); s.rm('-rf',
'{path}');".format(path=path)
    +    return ShellCommand(command=['node', '-e', js_script], **kwargs)
    +
    +def InstallShellJS():
    --- End diff --
    
    Why is it a global requirement? We run `npm install` in the medic directory when we use
it, and `grunt-cli` is inside `package.json`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message