cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: CB-5059 Add a CookieMan...
Date Wed, 28 Jan 2015 16:16:47 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/60#discussion_r23698327
  
    --- Diff: src/android/FileTransfer.java ---
    @@ -316,7 +316,7 @@ public void run() {
                         conn.setRequestProperty("Content-Type", "multipart/form-data; boundary="
+ BOUNDARY);
     
                         // Set the cookies on the response
    -                    String cookie = CookieManager.getInstance().getCookie(target);
    +                    String cookie = webView.getCookieManager().getCookie(target);
    --- End diff --
    
    I think we'll need to use reflection here to keep the plugin compatible with 3.x versions
of android.
    
    e.g.: Look at how getPluginManager() is handled on line 854.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message