cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-8307 - new 10yr cert and tools to...
Date Tue, 27 Jan 2015 21:45:27 GMT
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-windows/pull/55#issuecomment-71734265
  
    This may be better served living in cordova-coho which is the tool that we use to package
a release. 
    Or possibly have the generate_certificate.js call `npm install node-forge` so only people
who call `npm generatekey` will ever need it.
    
    I am not completely sure what the impact is of having node-forge as a dependency, it may
not be that big of a deal, but we will be looking at some point to remove npm_modules folder
and have platform installs actually use npm install directly. ie No bundling of the dependencies.
    
    Not sure what is the best approach here.
     
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message