cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From oliversalzburg <...@git.apache.org>
Subject [GitHub] cordova-wp8 pull request: Improved console logging
Date Mon, 26 Jan 2015 11:37:26 GMT
Github user oliversalzburg commented on the pull request:

    https://github.com/apache/cordova-wp8/pull/66#issuecomment-71448490
  
    Okay, I gave this a brief look and I'm not quite sure right now what the point of `ConsoleHelper.cs`
is. When I simply don't instantiate it, then `cordova-plugin-console` is used.
    
    Unless I'm missing something, I would assume that `ConsoleHelper.cs` should be completely
removed from the `cordova-wp8` project. This already gives better logging output.
    
    I definitely agree with you now that any changes to how arguments, which are passed to
the console logging facilities, are converted to strings, should be moved to `cordova-plugin-console`.
I will move our change there and send the appropriate pull request. I would also send one
for the removal of `ConsoleHelper.cs` unless I detect any problems down the road.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message