cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...
Date Thu, 22 Jan 2015 22:03:47 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-browser/pull/6#discussion_r23414226
  
    --- Diff: bin/lib/create.js ---
    @@ -75,7 +69,7 @@ exports.createProject = function(project_path,package_name,project_name){
             'run',
             'build',
             'clean',
    -        'version',
    +        'version'
    --- End diff --
    
    you shouldn't make this change. trailing commas are legal and in fact encouraged for arrays,
as they make diffs easier to read.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message