cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...
Date Thu, 22 Jan 2015 20:55:20 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/148#discussion_r23408933
  
    --- Diff: cordova-lib/src/cordova/platform.js ---
    @@ -423,7 +420,7 @@ function platform(command, targets, opts) {
                 // Neither path, nor platform name - throw.
                 var msg;
                 if (/[~:/\\.]/.test(t)) {
    -                msg = 'Platform path "' + t + '" not found.';
    +                return;
    --- End diff --
    
    This needs a code comment saying what's going on in this case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message