cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <>
Subject [GitHub] cordova-android pull request: CB-8317: Make it work to load about:...
Date Tue, 20 Jan 2015 15:21:06 GMT
Github user agrieve commented on a diff in the pull request:
    --- Diff: framework/src/org/apache/cordova/ ---
    @@ -171,8 +171,13 @@ public void onPageStarted(WebView view, String url, Bitmap favicon)
         public void onPageFinished(WebView view, String url) {
             super.onPageFinished(view, url);
             // Ignore excessive calls.
    -        if (!isCurrentlyLoading) {
    -            return;
    +        //     On KitKat, loading about:blank does not invoke WebViewClient#onPageStarted
    +        //     So do not check isCurrentLoading if app is running on KitKat
    +        //
    +        if (android.os.Build.VERSION.SDK_INT != android.os.Build.VERSION_CODES.KITKAT){
    --- End diff --
    You don't need to re-request a PR, but you do need to make the change an upload it to
github (either as a separate commit, or by force-pushing an ammended commit). Then, add a
comment to let me know you've done so and I'll pull it in (once you do it, it should show
up on this interface).

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message