cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shingotoda <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-8317: Make it work to load about:...
Date Tue, 20 Jan 2015 04:56:16 GMT
Github user shingotoda commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/149#discussion_r23202941
  
    --- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
    @@ -171,8 +171,13 @@ public void onPageStarted(WebView view, String url, Bitmap favicon)
{
         public void onPageFinished(WebView view, String url) {
             super.onPageFinished(view, url);
             // Ignore excessive calls.
    -        if (!isCurrentlyLoading) {
    -            return;
    +        //     On KitKat, loading about:blank does not invoke WebViewClient#onPageStarted
    +        //     So do not check isCurrentLoading if app is running on KitKat
    +        //         https://code.google.com/p/android/issues/detail?id=65701
    +        if (android.os.Build.VERSION.SDK_INT != android.os.Build.VERSION_CODES.KITKAT){
    --- End diff --
    
    So do I need to resend pull request again with revised patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message