cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...
Date Sun, 18 Jan 2015 01:42:38 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/148#discussion_r23130079
  
    --- Diff: cordova-lib/src/cordova/lazy_load.js ---
    @@ -284,4 +286,47 @@ function custom(platforms, platform) {
         });
     }
     
    +// Returns a promise
    +function git_clone(repository) {
    --- End diff --
    
    cordova-lib already has code to checkout from git:
    https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/util/plugins.js#L49
    
    Would be better to make it so that both paths use the same helper for checking out a git
repo.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message