cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-cli pull request: CB-8168 --list support for CLI
Date Fri, 16 Jan 2015 19:31:43 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/205#discussion_r23103363
  
    --- Diff: src/cli.js ---
    @@ -206,12 +207,13 @@ function cli(inputArgs) {
             // calling into platform code should be dealing with this based
             // on the parsed args object.
             var downstreamArgs = [];
    -        var argNames = [ 'debug', 'release', 'device', 'emulator', 'nobuild'];
    +        var argNames = [ 'debug', 'release', 'device', 'emulator', 'nobuild', 'list'];
    --- End diff --
    
    Someone should split this array initialization line into multiple lines, one line per
arg-name. But that doesn't have to be done in this commit.
    
    (Splitting it means that you don't get blame for the entire line each time you add/remove
an arg-name from the list, only for the one you're inserting/removing.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message