cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From IngusSkaistkalns <...@git.apache.org>
Subject [GitHub] cordova-plugin-device pull request: adds new property 'manufacture...
Date Thu, 15 Jan 2015 07:43:05 GMT
Github user IngusSkaistkalns commented on the pull request:

    https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-70050191
  
    @purplecabbage - maybe, but how do you expect to get string `samsung` from string like
this -> `Mozilla/5.0 (Linux; U; Android 4.4.2; en-gb; GT-I9505 Build/KOT49H) AppleWebKit/537.16
(KHTML, like Gecko) Version/4.0 Safari/537.16`, i guess this would require additional maintaining
of user-agents or model names in our administrative portal.
    Also I don't really understand point of why exposing manufacturer is _wrong_. Am I overlooking
some security issues or smth like that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message