cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request: Add Media.prototype.setRate met...
Date Thu, 15 Jan 2015 01:52:56 GMT
Github user purplecabbage commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/40#discussion_r22986048
  
    --- Diff: www/Media.js ---
    @@ -149,9 +149,21 @@ Media.prototype.release = function() {
      * Adjust the volume.
      */
     Media.prototype.setVolume = function(volume) {
    -    exec(null, null, "Media", "setVolume", [this.id, volume]);
    +    if (device.platform == 'iOS'){
    --- End diff --
    
    Doesn't this require the device plugin to be installed?
    Instead, you should use ``` if (cordova.platformId === 'ios') ...```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message