cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmocny <...@git.apache.org>
Subject [GitHub] cordova-plugin-test-framework pull request: CB-7459 Add header to ...
Date Wed, 14 Jan 2015 20:51:19 GMT
Github user mmocny commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-test-framework/pull/6#discussion_r22968802
  
    --- Diff: www/main.js ---
    @@ -215,6 +237,12 @@ function createEnablerList() {
     
       enablerList.appendChild(checkButtonBar);
       
    +  header.appendChild(headerPrefix);
    +  header.appendChild(enabledCount);
    +  header.appendChild(totalCount);
    +  header.appendChild(headerSuffix);
    --- End diff --
    
    This seems needlessly complex.  Why not just a single text element, and we set the whole
"Running X of Y" text each time?  We already append the '/' to the first span and we aren't
using any fancy data binding.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message