cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From basvanbeek <>
Subject [GitHub] cordova-plugin-device pull request: adds new property 'manufacture...
Date Wed, 14 Jan 2015 18:55:40 GMT
Github user basvanbeek commented on the pull request:
    @purplecabbage so while the Android API has implemented a method to easily get the Manufacturer
name from the device, we are declined to reach that method from the most obvious cordova plugin
to have this logic disclosed? And the rationale is that in your opinion we just have to parse
user-agent strings and build device model to brand mapping tables to get what we want and
keep on checking and updating the parsing logic / mapping tables all the time? Highly inefficient
and a pure waste of time. 
    If the cost of adding, maintaining and having this feature would be high I can understand
hesitation but cost is negligible and the cost for developers needing this information and
now having to resort to forking the plugin and keeping in sync with ongoing development or
even adding an additional plugin to each app requiring this feature sounds very user unfriendly
and also discourages people to contribute code if even the simplest of code updates get waved
away / neglected like this.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message