cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...
Date Wed, 14 Jan 2015 01:32:24 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-browser/pull/6#discussion_r22911133
  
    --- Diff: node_modules/.bin/shjs ---
    @@ -1 +1,15 @@
    -../shelljs/bin/shjs
    --- End diff --
    
    This is done automagically by node on windows to create a shim for a *nix batch file:
http://stackoverflow.com/questions/10396305/npm-package-bin-script-for-windows. While I agree
with you that this is not strictly related to `update` change, since this is in the `node_modules`
directory, I would prefer to keep this as is. Let me know if you still disagree. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message