cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...
Date Tue, 13 Jan 2015 23:32:24 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-browser/pull/6#discussion_r22905187
  
    --- Diff: bin/lib/update.js ---
    @@ -0,0 +1,59 @@
    +/*
    +       Licensed to the Apache Software Foundation (ASF) under one
    +       or more contributor license agreements.  See the NOTICE file
    +       distributed with this work for additional information
    +       regarding copyright ownership.  The ASF licenses this file
    +       to you under the Apache License, Version 2.0 (the
    +       "License"); you may not use this file except in compliance
    +       with the License.  You may obtain a copy of the License at
    +
    +         http://www.apache.org/licenses/LICENSE-2.0
    +
    +       Unless required by applicable law or agreed to in writing,
    +       software distributed under the License is distributed on an
    +       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +       KIND, either express or implied.  See the License for the
    +       specific language governing permissions and limitations
    +       under the License.
    +*/
    +
    +var Q      = require('Q'),
    +    create = require('./create'),
    +    fs     = require('fs'),
    +    shell = require('shelljs');
    +
    +module.exports.help = function () {
    +    console.log("WARNING : Make sure to back up your project before updating!");
    +    console.log("Usage: update PathToProject ");
    +    console.log("    PathToProject : The path the project you would like to update.");
    +    console.log("examples:");
    +    console.log("    update C:\\Users\\anonymous\\Desktop\\MyProject");
    +};
    +
    +module.exports.run = function (argv) {
    +    var projectPath = argv[2];
    +    if (!fs.existsSync(projectPath)) {
    +        // if specified project path is not valid then reject promise
    +        Q.reject("Browser platform does not exist here: " + projectPath);
    +    }
    +    return Q().then(function() {
    +        console.log("Removing existing browser platform.");
    +        shellfatal(shell.rm, '-rf', projectPath);
    +        create.createProject(projectPath);
    +    });
    +}
    +
    +function shellfatal(shellFunc)
    +{
    +    var slicedArgs = Array.prototype.slice.call(arguments, 1);
    +    try
    +    {
    +        shell.config.fatal = true;
    +        var returnVal = shellFunc.apply(shell, slicedArgs);
    +    }   
    +    finally
    +    {
    +        shell.config.fatal = false;
    +    }
    +    return returnVal;
    +}
    --- End diff --
    
    Interesting! I will fix this. I'm curious - what's the rationale behind this? Is this
just a styling best practice on this project or in JavaScript community?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message