cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <>
Subject [GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...
Date Tue, 13 Jan 2015 23:29:49 GMT
Github user nikhilkh commented on a diff in the pull request:
    --- Diff: bin/lib/create.js ---
    @@ -26,14 +26,11 @@ var fs = require('fs'),
         ROOT    = path.join(__dirname, '..', '..'),
         check_reqs = require('./check_reqs');
     exports.createProject = function(project_path,package_name,project_name){
         var VERSION = fs.readFileSync(path.join(ROOT, 'VERSION'), 'utf-8');
         // Set default values for path, package and name
         project_path = typeof project_path !== 'undefined' ? project_path : "CordovaExample";
    -    package_name = typeof package_name !== 'undefined' ? package_name : 'org.apache.cordova.example';
    --- End diff --
    Turns out that `update` depends on `create`. As I mentioned in my pull request, I had
to remove these console.log messages as for the browser platform we do not save the package
and project name on creation. On upgrade, I do not have a package and project name when I
invoke `createProject`. These messages had marginal value so I decided to remove them. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message