cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...
Date Tue, 13 Jan 2015 22:20:18 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/148#discussion_r22900366
  
    --- Diff: cordova-lib/src/cordova/platform.js ---
    @@ -76,97 +77,94 @@ function add(hooksRunner, projectRoot, targets, opts) {
         }
     
         return hooksRunner.fire('before_platform_add', opts)
    -    .then(function() {
    -        return promiseutil.Q_chainmap(targets, function(target) {
    -            // For each platform, download it and call its "create" script.
    -            var parts = target.split('@');
    -            var platform = parts[0];
    -            var version = parts[1];
    -
    -            return Q.when().then(function() {
    -                if (!(platform in platforms)) {
    -                    return getPlatformDetailsFromDir(target);
    -                } else {
    -                    if (!version) {
    -                        events.emit('verbose', 'No version supplied. Retrieving version
from config.xml...');
    -                    }
    -                    version = version || getVersionFromConfigFile(platform, cfg);
    -                    var tgt = version ? (platform + '@' + version) : platform;
    -                    return isDirectory(version) ? getPlatformDetailsFromDir(version)
: downloadPlatform(projectRoot, tgt, opts);
    -                }
    -            }).then(function(platDetails) {
    -                var template = config_json && config_json.lib && config_json.lib[platform]
&& config_json.lib[platform].template || null;
    -                return call_into_create(platDetails.platform, projectRoot, cfg, platDetails.libDir,
template, opts);
    -            });
    -        });
    -    })
    -    .then(function() {
    -        return hooksRunner.fire('after_platform_add', opts);
    -    });
    +	.then(function () {
    --- End diff --
    
    please don't insert tabs. and please try to avoid rewriting large chunks of files when
adding features.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message