cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...
Date Tue, 13 Jan 2015 22:19:26 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/148#discussion_r22900311
  
    --- Diff: cordova-lib/spec-cordova/platform.spec.js ---
    @@ -354,22 +359,94 @@ describe('add function', function () {
             });
         });
     
    -    it('fails if there is an error while getting the platform details', function (done)
{
    +    it('tries to git-clone if there is an error while getting the platform details as
specified from the command line', function (done) {
     
    -        var targets = ['C:\\Projects\\cordova-projects\\cordova-android'];
    +        var targets = ['https://github.com/apache/cordova-android'],
    +	    targetPlatform = 'android',
    +	    libDir = 'C:\\Projects\\cordova-projects\\cordova-android-clone-directory';
    +
    +	var cloneGitRepoMock = jasmine.createSpy().andReturn(Q({
    +	    platform: targetPlatform,
    +	    libDir: libDir
    +	}));
    +	platform.__set__('cloneGitRepo', cloneGitRepoMock);
    --- End diff --
    
    you're inserting some tabs.
    
    in general, tabs are frowned upon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message