cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...
Date Tue, 13 Jan 2015 19:30:23 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/143#discussion_r22887338
  
    --- Diff: framework/src/org/apache/cordova/HttpAuthRequestHandler.java ---
    @@ -0,0 +1,30 @@
    +/*
    +       Licensed to the Apache Software Foundation (ASF) under one
    +       or more contributor license agreements.  See the NOTICE file
    +       distributed with this work for additional information
    +       regarding copyright ownership.  The ASF licenses this file
    +       to you under the Apache License, Version 2.0 (the
    +       "License"); you may not use this file except in compliance
    +       with the License.  You may obtain a copy of the License at
    +
    +         http://www.apache.org/licenses/LICENSE-2.0
    +
    +       Unless required by applicable law or agreed to in writing,
    +       software distributed under the License is distributed on an
    +       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +       KIND, either express or implied.  See the License for the
    +       specific language governing permissions and limitations
    +       under the License.
    +*/
    +package org.apache.cordova;
    +
    +import android.webkit.HttpAuthHandler;
    +import android.webkit.WebView;
    --- End diff --
    
    For android-4.0.x, we're trying to do away with referring to android.webkit.WebView explicitly.
It'd be better to pass in the CordovaWebView, and to create an abstraction around HttpAuthHandler
that just wraps the webkit one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message