Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: oliversalzburg <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
Message-ID: <git-pr-66-cordova-wp8@git.apache.org>
Subject: [GitHub] cordova-wp8 pull request: Improved console logging
Content-Type: text/plain
Date: Fri, 12 Dec 2014 10:40:34 +0000 (UTC)

GitHub user oliversalzburg opened a pull request:

    https://github.com/apache/cordova-wp8/pull/66

    Improved console logging

    Previously, when using console.log facilities, only the first argument was respected by ConsoleHelper, resulting in information not being logged when `console.log` was invoked with multiple arguments.
    Additionally, arguments would be converted straight to strings, resulting in `[object Object]` or similar results in the log.
    
    This change allows any number of arguments to be passed to the logging functions and it converts the inputs to a representation that is useful when debugging the application.
    
    A call like `log( "a", 123, { foo: 'bar' }, function() { return 'baz'; } );`
    Results in: `a,123,{"foo":"bar"},function () { return 'baz'; }`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hartwig-at/cordova-wp8 feature/console-helper

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-wp8/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #66
    
----
commit c00511a20a823e5f78b0fcbbce50d247e4adac8c
Author: Oliver Salzburg <oliver.salzburg@gmail.com>
Date:   2014-12-12T10:29:02Z

    Improved console logging
    Previously, when using console.log facilities, only the first argument was
    respected by ConsoleHelper, resulting in information not being logged when
    console.log was invoked with multiple arguments.
    Additionally, arguments would be converted straight to strings, resulting
    in [object Object] or similar results in the log.
    
    This change allows any number of arguments to be passed to the logging
    functions and it converts the inputs to a representation that is useful
    when debugging the application.
    
    A call like log( "a", 123, { foo: 'bar' }, function() { return 'baz'; } );
    Results in: a,123,{"foo":"bar"},function () { return 'baz'; }

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org