Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of mmocny@google.com designates
 209.85.220.178 as permitted sender)
MIME-Version: 1.0
Sender: mmocny@google.com
In-Reply-To: 
 <CAOBL_k6VboP2r_cGvBg-W_nNe2MfEvm0HeobtgCdK9BxhTGxCA@mail.gmail.com>
References: 
 <CABiQX1Wo9dHsknN8qT=fEKP1jsqCiVrrJ2ee_D5fG2-S04o7JQ@mail.gmail.com>
 <CABiQX1XiQ8vpkq6GVV3Q=2BoikCdvuFZLX2gm9J2V=gtM614NQ@mail.gmail.com>
 <CAOBL_k6VboP2r_cGvBg-W_nNe2MfEvm0HeobtgCdK9BxhTGxCA@mail.gmail.com>
From: Michal Mocny <mmocny@chromium.org>
Date: Mon, 8 Dec 2014 10:40:15 -0500
Message-ID: 
 <CAEeF2TfDjg7FT=1WRqMaG4AO5GwaVdZ266z2kdbJUBHfjgC=uQ@mail.gmail.com>
Subject: Re: Code Review Plz
To: dev <dev@cordova.apache.org>
Cc: Andrew Grieve <agrieve@chromium.org>
Content-Type: multipart/alternative; boundary=001a11364926613f8f0509b63f33

--001a11364926613f8f0509b63f33
Content-Type: text/plain; charset=UTF-8

Sorry didn't answer.  I looked a week ago and liked the design and
rationale, but don't have existing apps actually using the feature to test
on.

On Fri, Dec 5, 2014 at 4:40 PM, Joe Bowser <bowserj@gmail.com> wrote:

> I'll take a look on Monday. Spent this week bashing my head against my desk
> trying to deal with the MozillaView js.
>
> On Fri, Dec 5, 2014, 1:12 PM Andrew Grieve <agrieve@chromium.org> wrote:
>
> > Will go ahead with this next week if no one has a look. That said, would
> > love a look.
> >
> > On Wed, Nov 26, 2014 at 10:10 PM, Andrew Grieve <agrieve@chromium.org>
> > wrote:
> >
> > > I've taken a stab at refactoring Android's splashscreen logic into the
> > > splashscreen plugin.
> > >
> > > https://github.com/apache/cordova-android/pull/134
> > > https://github.com/apache/cordova-plugin-splashscreen/pull/32
> > >
> > > In order to be backwards-compatible, I've:
> > >  - Committed a copy of the plugin to cordova-android and registered it
> > > where App is registered
> > >  - Made the new code in the actual plugin disabled if it detects
> > > cordova-android < 4.0
> > >
> > >
> > > I've also deprecated splash-screen related things within
> CordovaActivity,
> > > because I don't think the Activity needs explicit logic in it for
> splash
> > > screens now that its a proper plugin (plus, you can do everything with
> > > config.xml or CordovaPreferences).
> > >
> > > My thinking is to delete the deprecated things when I merge into the
> > > 4.0.x, and to also remove the bundled copy of the plugin.
> > >
> > > To test this, I've enabled the splashscreen on Android in mobilespec.
> For
> > > the life of me I couldn't get the instruments test in cordova-android
> to
> > > run. My Eclipse doesn't boot, Android Studio does an awful job
> importing
> > > it, and the command-line instructions in the README yield:
> > >     [aapt] invalid resource directory name:
> > > /Users/agrieve/git/cordova/cordova-android/test/bin/res/crunch
> > >
> > > ugh! Certainly it'd be worth getting these working, but I think
> > mobilespec
> > > is a better test for this anyways since I could test with & without the
> > > plugin installed.
> > >
> > > Andrew
> > >
> > >
> > >
> >
>

--001a11364926613f8f0509b63f33--