Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5374B1099A for ; Mon, 1 Dec 2014 18:16:26 +0000 (UTC) Received: (qmail 60093 invoked by uid 500); 1 Dec 2014 18:16:25 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 60059 invoked by uid 500); 1 Dec 2014 18:16:25 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 60047 invoked by uid 99); 1 Dec 2014 18:16:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Dec 2014 18:16:25 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of agrieve@google.com designates 209.85.218.54 as permitted sender) Received: from [209.85.218.54] (HELO mail-oi0-f54.google.com) (209.85.218.54) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Dec 2014 18:15:58 +0000 Received: by mail-oi0-f54.google.com with SMTP id u20so7771517oif.41 for ; Mon, 01 Dec 2014 10:13:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:from:date:message-id:subject:to:cc:content-type; bh=ofZiyyUbJjbXI18VzrDyQBJLOm7PuplyJQ87yeHIw9U=; b=MH83yN2FK+kqqhA+CTHvkORlqU1V0saEI5oQHKPivQs+slYHiZ90O3XJvLMA7tkcme Y6YBsTPNu36OO4Z8DuBYRfWAKk8c1kptVC6BF9TBkhCOW20EGgvTC0N77kN9ZLa3/w1X evIg0l4oHxkilfNb9h2bEJkIQBBYRbxCbopuT95S3BCnlXhR3itdu3xZAlgzDXcwpq2s A+DyDIJ8YWYmVQ5aAapbU0Y4F6QmimU+f1E1zKjE5enV4yq6W9suBarQQcu9DClfHG7v vC+CEiOm6jlE8ndmlRLReThElTE4yZcdnka8kgOxnxJ2eiXXJ5Ez3Z2cDHQ+3ICxKKbS sU8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc :content-type; bh=ofZiyyUbJjbXI18VzrDyQBJLOm7PuplyJQ87yeHIw9U=; b=KxLLS1EhKJNE5kruBMS+S+QS6GuWL5d8NKPHj5nQOb/osbQNPgqhK1aXn5tLdlBpL4 fuTFaA9D0UEb+RvDTHSvk7tvV3CuERr12Joxv4/mbFhJb8kq6T5oDeQu3xFumlZ3GxnQ u0cYn04RMDkXYCWz/fjw953bzOIwDe6MSSnGkI7oiIg4YmTth0jobHT1vtci+/MviQ4o 8TAy2MHUS6J6K5Y8efasB45Y0qDdpujpCyH3SoxqV6SCUKSTBCoWzed4OhSKH1iy4lxM c8+R6/ZtKqjRMgc1M30BLZ/V771+MSdXbU5rQ85g3BVkt481FqlrpGO61DDN889Eq1sl oleg== X-Gm-Message-State: ALoCoQlmRWpVtsWUuxAwr2676D4ITFivfRnXwS7Dvhwc38oGmyQRSCmXwztlJ3BSd5Y4j3Bm8QVb X-Received: by 10.60.161.41 with SMTP id xp9mr13922270oeb.0.1417457622475; Mon, 01 Dec 2014 10:13:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.222.106 with HTTP; Mon, 1 Dec 2014 10:13:22 -0800 (PST) From: Andrew Grieve Date: Mon, 1 Dec 2014 13:13:22 -0500 Message-ID: Subject: WKWebView fly-by code review comment To: Shazron Abdullah Cc: dev Content-Type: multipart/alternative; boundary=089e01184802128be705092b9210 X-Virus-Checked: Checked by ClamAV on apache.org --089e01184802128be705092b9210 Content-Type: text/plain; charset=UTF-8 When working on CB-8002, noticed this code: commandQueue.push(JSON.stringify(command)); if (bridgeMode === jsToNativeModes.WK_WEBVIEW_BINDING) { window.webkit.messageHandlers.cordova.postMessage(command); Wondering if maybe when in WK_WEBVIEW mode, if commands are being added to commandQueue and never dequeued. Maybe fix is to never add them to the queue? --089e01184802128be705092b9210--