Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: kamrik <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-46-cordova-plugin-dialogs@git.apache.org>
In-Reply-To: <git-pr-46-cordova-plugin-dialogs@git.apache.org>
Subject: [GitHub] cordova-plugin-dialogs pull request: Added support for the
 new "br...
Content-Type: text/plain
Message-Id: <20141211193902.97C8FA27186@tyr.zones.apache.org>
Date: Thu, 11 Dec 2014 19:39:02 +0000 (UTC)

Github user kamrik commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/46#discussion_r21702976
  
    --- Diff: www/browser/notification.js ---
    @@ -0,0 +1,94 @@
    +// Platform: browser
    +window.navigator.notification = window.navigator.notification || {};
    +
    +module.exports.alert = window.navigator.notification.alert = function(message, callback) {
    +    // `notification.alert` executes asynchronously
    +    setTimeout(function() {
    +        window.alert(message);
    --- End diff --
    
    I think this will block all of js execution until the dialog is dismissed?
    This shouldn't be an issue for many cases, but it will result in a different behavior compared to android implementation where it's completely async. Actually I was working on an async implementation of this for browser. So I would be glad if this goes in and then I'll add my part on top.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org