cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From coryjthompson <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Fix terminology for selecting ...
Date Tue, 16 Dec 2014 06:05:11 GMT
GitHub user coryjthompson opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/58

    Fix terminology for selecting a video.

    Selecting a video currently shows 'Videos title' along the top of the picker.
    
    I believe 'Videos' would be more appropriate. 
    
    The reason it was changed was for localization, which unless I am mistaken has been removed.
    
    (Old commit showing it was previously 'Videos' until localization was added. Probably
completely irrelevant)
    https://github.com/coryjthompson/cordova-ios/commit/8b0f11fd60bf6966bd40d296cd80b96e2cef6806
    
    Thanks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/coryjthompson/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #58
    
----
commit 47ece47f5af55333d864fca0b79b825003f86211
Author: Cory Thompson <coryjthompson@gmail.com>
Date:   2014-12-16T05:50:56Z

    Fixed terminology for selecting a video.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message