cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hurtyto <...@git.apache.org>
Subject [GitHub] cordova-plugin-dialogs pull request: Breaking on Windows Phone 8
Date Mon, 01 Dec 2014 08:39:36 GMT
GitHub user Hurtyto opened a pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/45

    Breaking on Windows Phone 8

    The curren version in the original (master) repository breaks the build due to conflicting
namaspace resolution;
    Class "Orientation" is present in both "System.Windows.Controls" and "WPCordovaClassLib.Cordova.Commands".
    Proposed resolution: Use full namespace notation "System.Windows.Controls.Orientation.Vertical"

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Hurtyto/cordova-plugin-dialogs patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-dialogs/pull/45.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #45
    
----
commit 8a972c698452855800424f610f7afa30ddd858d1
Author: Hurtyto <georgi.ivp@gmail.com>
Date:   2014-12-01T08:39:22Z

    Breaking on Windows Phone 8
    
    The curren version in the original (master) repository breaks the build due to conflicting
namaspace resolution;
    Class "Orientation" is present in both "System.Windows.Controls" and "WPCordovaClassLib.Cordova.Commands".
    Proposed resolution: Use full namespace notation "System.Windows.Controls.Orientation.Vertical"

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message