cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BigstickCarpet <...@git.apache.org>
Subject [GitHub] cordova-plugin-device pull request: Internet Explorer browser supp...
Date Thu, 11 Dec 2014 20:41:27 GMT
GitHub user BigstickCarpet opened a pull request:

    https://github.com/apache/cordova-plugin-device/pull/28

    Internet Explorer browser support

    Added support for Internet Explorer and other browsers when using the new "browser" platform
in Cordova 4.
    
    Chrome, Safari, and Firefox were already supported, but when using IE or any other browser
an error would occur because the user agent string wasn't recognized.
    
    I added specific logic to parse Internet Explorer's user agent string.  Note that IE 11's
user agent string doesn't include "MSIE", so I search for "Trident" instead.
    
    I also fixed the bug that caused an error if the user agent wasn't recognized, so if a
browser other than Chrome, Safari, Firefox, or IE is used, the plugin will still work.  It
just won't have the `device.model` or `device.version` set.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BigstickCarpet/cordova-plugin-device master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-device/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #28
    
----
commit 3f1e1c96b775653b6a594be1b39d34b8df45772b
Author: James Messinger <james.messinger@ventyx.abb.com>
Date:   2014-12-11T20:26:37Z

    - Fixed a bug that caused an "cannot call method of undefined" error if the browser's
user agent wasn't recognized
    - Added support for Internet Explorer user agent strings
    - NOTE: IE 11's user agent string does not include "MSIE", so "Trident" is searched for
instead

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message