cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From IvanKarpan <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar pull request: CB-8001
Date Fri, 12 Dec 2014 10:45:00 GMT
GitHub user IvanKarpan opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/19

    CB-8001

    StatusBar Plugin 0.1.8 crashes application on tap
    Reproduced only in projects without ARC
    Now retaining callbackId, without a retain there it gets dealloced and crashes the app
when fireTappedEvent is triggered

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/IvanKarpan/cordova-plugin-statusbar patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19
    
----
commit 3c7c328ac16a4d4e0edf1d6562a0b832a0202582
Author: Ivan Karpan <ivan.karpan@gmail.com>
Date:   2014-12-12T10:44:20Z

    CB-8001
    
    StatusBar Plugin 0.1.8 crashes application on tap
    Reproduced only in projects without ARC
    Now retaining callbackId, without a retain there it gets dealloced and crashes the app
when fireTappedEvent is triggered

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message