cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <>
Subject Re: WKWebView fly-by code review comment
Date Mon, 01 Dec 2014 19:49:12 GMT
It actually is dequeued:

However you are right, it never really needs to get enqueued in the
first place for that mode. The CDVCommandQueue is still there in the
wkwebview branch because initially I was trying to shoehorn in
wkwebview support, without changing the overall architecture.

On Mon, Dec 1, 2014 at 10:13 AM, Andrew Grieve <> wrote:
> When working on CB-8002, noticed this code:
>     commandQueue.push(JSON.stringify(command));
>     if (bridgeMode === jsToNativeModes.WK_WEBVIEW_BINDING) {
>         window.webkit.messageHandlers.cordova.postMessage(command);
> Wondering if maybe when in WK_WEBVIEW mode, if commands are being added to
> commandQueue and never dequeued. Maybe fix is to never add them to the
> queue?

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message