cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: --list argument for CLI
Date Mon, 22 Dec 2014 14:01:39 GMT
Code style issues and minor refactoring CLs don't require JIRA issues. Just
create a JIRA if you're changing behaviour in some way (e.g. bug fix, new
feature)

On Fri, Dec 19, 2014 at 3:55 PM, Murat Sutunc <muratsu@microsoft.com> wrote:
>
> Hi Josh,
> Amazing feedback, thank you for spending the time going through all the
> changes!
> I've read the wiki page you mentioned before but looks like I've missed
> the section of it regarding commit messages, my bad.
>
> I have a question about decoupling of feature work and other tasks (such
> as code style issues and refactoring). Should other tasks also be tagged
> with the original feature CB tag? Or should I just treat them as a separate
> item with a separate CB tag and make a new pull request for it?
>
> Thanks,
> Murat
>
> -----Original Message-----
> From: Josh Soref [mailto:jsoref@blackberry.com]
> Sent: Friday, December 19, 2014 8:08 AM
> To: dev@cordova.apache.org
> Subject: RE: --list argument for CLI
>
> Murat wrote:
> > I've the initial work available as pull requests here:
> > cordova-cli: https://github.com/apache/cordova-cli/pull/199
> > cordova-android: https://github.com/apache/cordova-android/pull/139
> > cordova-ios: https://github.com/apache/cordova-ios/pull/122
>
> > If anyone has time to go through the pull requests and accept, that
> would be fantastic!
>
> Hi murat,
> Sorry for not getting around to them sooner. They were on my list of
> things I am interested in.
>
> A colleague asked me about something related, so I just spent the time to
> give feedback.
>
> Before you take the time to read my feedback, I'd like to get you to think
> back to how you started working on Cordova.
>
> Which web pages / documentation did you find/read?
> What did they take you to?
> Where there sections that you skipped because "I already know how to do X"?
>
> Then, read through the wiki page I mentioned in the feedback. If that wiki
> page wasn't one of the ones you already read, then please indicate what you
> read. Because we need to ensure that contributors do see it. Also, if any
> of the things I've mentioned aren't listed in the pages that you will have
> read, please let us know so that we can fix them :).
>
> If you skipped a section, and it turns out that the section has relevant
> content, please let us know, in one case, a section's name hinted to
> someone that it was standard stuff when in fact it had other important
> Cordova specific details, so we tried to rename the link (I don't know if
> it worked, you're perhaps the first person who can tell me...).
>
> Thanks, and welcome.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message