cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-8210 Setup message channel for na...
Date Wed, 24 Dec 2014 18:37:33 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/142#discussion_r22261664
  
    --- Diff: framework/src/org/apache/cordova/LinearLayoutSoftKeyboardDetect.java ---
    @@ -87,14 +85,12 @@ else if (screenHeight == width)
             // If the height as gotten bigger then we will assume the soft keyboard has
             // gone away.
             else if (height > oldHeight) {
    -            if (app != null)
    -                app.appView.sendJavascript("cordova.fireDocumentEvent('hidekeyboard');");
    +            App.fireJavascriptEvent("hidekeyboard");
    --- End diff --
    
    Rather than use a static method, it'd be better to use webView.pluginManager.getPlugin("org.apache.cordova.App")
to get the instance-specific plugin instance


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message