cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: allow to add a plugin from drive differe...
Date Tue, 23 Dec 2014 16:57:41 GMT
Github user agrieve commented on the pull request:

    https://github.com/apache/cordova-lib/pull/135#issuecomment-67972984
  
    Thanks for the patch! Looks like in a couple of other files, we do:
        ./cordova/config.js:        else if (uri.protocol && uri.protocol[1] ==':')
return uri.href;
        ./cordova/lazy_load.js:    isUri = uri.protocol && uri.protocol[1] != ':';
    
    So, I've used that check instead of your PR to make the fix.
    The relevant JIRA issue is https://issues.apache.org/jira/browse/CB-7610


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message