cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-android pull request: --list support for android
Date Fri, 19 Dec 2014 15:51:04 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/139#discussion_r22110967
  
    --- Diff: bin/lib/check_reqs.js ---
    @@ -59,9 +59,13 @@ module.exports.get_target = function() {
             return extractFromFile(path.join(ROOT, 'framework', 'project.properties'));
         }
         if (fs.existsSync(path.join(ROOT, 'project.properties'))) {
    -        // if no target found, we're probably in a project and project.properties is
in ROOT.
    +        // we can be in a project and project.properties can be in ROOT.
             return extractFromFile(path.join(ROOT, 'project.properties'));
         }
    +    if (fs.existsSync(path.join(ROOT, '..', '..', 'framework', 'project.properties')))
{
    +        // if not found, we can be testing.
    +        return extractFromFile(path.join(ROOT, '..', '..', 'framework', 'project.properties'));
    +    }
    --- End diff --
    
    I don't see how this relates to the feature work you're doing, it should probably be a
distinct commit and probably have a distinct CB-number in http://issues.apache.org/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message