cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-android pull request: Fixed javascript not loading when ac...
Date Thu, 11 Dec 2014 01:28:55 GMT
Github user agrieve commented on the pull request:

    https://github.com/apache/cordova-android/pull/128#issuecomment-66555726
  
    Created issue for this: https://issues.apache.org/jira/browse/CB-8146.
    
    Nice job tracking this down! I'd go even one step further to what Joe said and claim that
`activityState` isn't necessary at all. I'd guess whoever put it in there originally just
didn't know about the `isFinishing()` getter :S. 
    
    Going to merge in your change so that you get some credit for tracking it down, then will
refactor to just delete `activityState`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message