cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-7803 allow adding any platform on any...
Date Tue, 02 Dec 2014 07:46:02 GMT
Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/126#issuecomment-65193737
  
    Hey @eymorale, to be honestly I'm out of context of why we adding (or need) this functionality
but one thing I noticed is you are using console.log. I would recommend to use  events.emit
so that trace could be controlled using verbosity flag and for consistency reasons


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message