cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation pull request: CB-8094 Pended autotests ...
Date Mon, 01 Dec 2014 07:25:30 GMT
Github user sgrebnov commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/33#discussion_r21073465
  
    --- Diff: tests/tests.js ---
    @@ -27,6 +27,7 @@ exports.defineAutoTests = function () {
             expect(true).toBe(true);
             done();
         };
    +    var isWindowsStore = (cordova.platformId == "windows" && navigator.appVersion.indexOf("Windows
Phone 8.1;")== -1) || (navigator.appVersion.indexOf("MSAppHost/1.0") !== -1)
    --- End diff --
    
    I would recommend to use the following way to detect windows desktop/tablet apps
    var isWindowsStore = (cordova.platformId == "windows8") ||  && (cordova.platformId
== "windows" && !WinJS.Utilities.isPhone)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message