Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of mmocny@google.com designates
 209.85.223.178 as permitted sender)
MIME-Version: 1.0
Sender: mmocny@google.com
In-Reply-To: 
 <CAHcDwFy-f8N8gOhOGTXxQ_tGWqfMN_gnY-9bF2LMmPKLDdgOSw@mail.gmail.com>
References: 
 <CAHcDwFzELMLLqwsUB9Lhc4jMriHz6M1F5u0tizkMJreo+wMc2A@mail.gmail.com>
 <CAE6O_-bdqo5KQ0+fc0tfdGdro8g=rywHgAvNJYO4Vc-5whV5UA@mail.gmail.com>
 <CAKP6k2sgYP+U5cQCKzbovFs3Tn2vxHj6WDZnQwJjFKC=W-7ATA@mail.gmail.com>
 <CAHcDwFy-f8N8gOhOGTXxQ_tGWqfMN_gnY-9bF2LMmPKLDdgOSw@mail.gmail.com>
From: Michal Mocny <mmocny@chromium.org>
Date: Tue, 11 Nov 2014 14:18:14 -0500
Message-ID: 
 <CAEeF2Td6kpB4eF2H_1V8WTrYBELWVumPtVCqkp1dv+wyd2XOew@mail.gmail.com>
Subject: Re: plugin.xml config-file for json files
To: dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=089e0141a76a442ae605079a25e2

--089e0141a76a442ae605079a25e2
Content-Type: text/plain; charset=UTF-8

I'd also recommend hooks for now.

<json-file> tag sounds potentially more resilient to change, but since you
have to explicitly reference the path to target I don't think its any
better in practice.

Additionally, we've expressed interest in replacing our xml based configs
with json manifests, and while that work may not be in a hurry, it seems
counterproductive to extend the scope of plugin/app configs right now.

-Michal

On Tue, Nov 11, 2014 at 2:09 PM, Axel Nennker <ignisvulpis@gmail.com> wrote:

> I would not modify the value. Can config-file replace values?
> Just adding stuff would be good enough for my (current) purposes.
> I would throw on existing keys.
> When two plugins add the same key then plugman should throw and I don't
> want to track all changes over all plugins.
>
> 2014-11-11 19:58 GMT+01:00 Jesse <purplecabbage@gmail.com>:
>
> > I would like to see a new element titled 'json-file' and matching parser
> > that does the work.
> > something like this?
> >
> > <json-file target="someManifest.json" parent="some.object.path">
> > "{the:{stringValue:2,b:"added"},or:{modified:true}}"
> > </json-file>
> >
> >
> > @purplecabbage
> > risingj.com
> >
> > On Tue, Nov 11, 2014 at 9:02 AM, Shazron <shazron@gmail.com> wrote:
> >
> > > Have you considered plugin hooks?
> > > I just implemented this yesterday to modify the root config.xml file:
> > >
> > >
> >
> https://github.com/apache/cordova-plugins/blob/master/local-webserver/plugin.xml
> > >
> > > On Tuesday, November 11, 2014, Axel Nennker <ignisvulpis@gmail.com>
> > wrote:
> > >
> > > > Hi,
> > > >
> > > > if I remember correctly then this was discussed before but I can't
> find
> > > the
> > > > email exchange.
> > > >
> > > > We are trying to use our cordova app on firefoxos and would like to
> > > modify
> > > > manifest.webapp which is a json file.
> > > >
> > > > In plugin.xml we can only modify xml files using the config-file
> > element.
> > > >
> > > > What are your preference on how to implenent this?
> > > > - reuse config-file with new attribute type="json" (default "xml")
> > > >   or new element e.g. "config-file-json"
> > > > - only adding to the json and throw if key already exists?
> > > > - ...
> > > >
> > > > Should I file an issue and implement it?
> > > >
> > > > cheers
> > > > Axel
> > > >
> > >
> >
>

--089e0141a76a442ae605079a25e2--