Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
From: Dan Polivy <dan@cellartracker.com>
To: "'dev@cordova.apache.org'" <dev@cordova.apache.org>
Subject: WP: Issue with fix for [CB-7028]
Thread-Topic: WP: Issue with fix for [CB-7028]
Thread-Index: AdAFZXXoz4bOdtX9TB6vnZPzVUKOfA==
Date: Fri, 21 Nov 2014 08:37:26 +0000
Message-ID: 
 <749d3edd75df4e9a871d7f857777aa76@EXBE003SV3.NA02.MSEXCHANGEOUTLOOK.COM>
Accept-Language: en-US
Content-Language: en-US
Content-Type: multipart/alternative;
	boundary="_000_749d3edd75df4e9a871d7f857777aa76EXBE003SV3NA02MSEXCHANG_"
MIME-Version: 1.0

--_000_749d3edd75df4e9a871d7f857777aa76EXBE003SV3NA02MSEXCHANG_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi folks,

I added a comment to the JIRA issue, but wanted to flag it here for discuss=
ion as well. I think I've uncovered a big issue with the fix that went in f=
or this issue on Windows Phone:

https://issues.apache.org/jira/browse/CB-7028

I have a plugin that uses a Windows Phone Task (inherits from Microsoft.Pho=
ne.Tasks.ChooserBase<> -- more details<http://msdn.microsoft.com/en-us/libr=
ary/windows/apps/ff769542(v=3Dvs.105).aspx>); when it is invoked from scrip=
t, it appears to result in the WebBrowser sending an Unloaded event. Due to=
 the change for CB-7028, all callbacks are subsequently unregistered/remove=
d. So, when my task chooser returns with data to send back to JavaScript, i=
t can no longer find any callbacks because the ResultHandlers dictionary is=
 now empty.

While the intent of the change looks reasonable, I wonder if there's perhap=
s a way to test whether the current command has any associated callbacks, a=
nd NOT wipe those out, while still potentially cleaning up others? However,=
 I haven't yet done enough investigation to know whether those callbacks th=
at get wiped out are properly re-created when the WebBrowser resumes contro=
l of the app - if not, this may be an even bigger issue.

Thoughts or suggestions? I'm not subscribed to the list, so please include =
me directly in any replies.

Thanks,
Dan


--_000_749d3edd75df4e9a871d7f857777aa76EXBE003SV3NA02MSEXCHANG_--