cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattgrande <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request: Add seekCompleteCallback to see...
Date Fri, 14 Nov 2014 13:40:47 GMT
GitHub user mattgrande opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/37

    Add seekCompleteCallback to seekTo.

    I had created an audio sprite elsewhere:
    
        var sprite = new Media(/* omitted */);
        sprite.play();
        sprite.pause();
    
    Then, further along, went to play the clip:
    
        sprite.seekTo( track.startTime );
        sprite.play();
    
    In iOS 7 and below, as well as Android, this worked. However, in iOS 8, nothing would
be played. When I inspected the position, `spirte._position`, a value of `-1` was shown. Basically,
seeking to a position took some undetermined amount of time, and the audio couldn't be played
until the seek had completed.
    
    This pull request adds a callback to the `seekTo` method that is fired when the seek is
complete.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattgrande/cordova-plugin-media master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
    
----
commit 730b1dbef264ffd8aab45a9bde5d13066716af58
Author: Matt Grande <matt@weeverapps.com>
Date:   2014-11-13T23:22:41Z

    Add seekCompleteCallback to seekTo.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message