cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation pull request: CB-8085 Fix geolocation p...
Date Wed, 26 Nov 2014 20:27:42 GMT
GitHub user sgrebnov opened a pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/32

    CB-8085 Fix geolocation plugin on Windows

    https://issues.apache.org/jira/browse/CB-8085
    
    This patch adds keepCallback property to tell proxy preserve callback so that it could
be invoked next time.
    
    When running on Windows Phone 8.1: added dummy 1 meter value for geolocator.movementThreshold
to prevent the following error (no such problem  when running on Windows 8/8.1)
    ```
    // JavaScript runtime error: Operation aborted
    // You must set the MovementThreshold property or the ReportInterval property before adding
event handlers.
                
    ```
    http://blogs.windows.com/buildingapps/2012/12/03/geoposition-advanced-tracking-scenarios-for-windows-phone-8/

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-geolocation CB-8085

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-geolocation/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit e3f9685993975cdc59283e4d5b0940cc293ed83b
Author: sgrebnov <v-segreb@microsoft.com>
Date:   2014-11-26T20:24:51Z

    CB-8085 Fix geolocation plugin on Windows

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message